Skip to content

Conversation

matthiaskrgr
Copy link
Member

Backports rust-lang/rust-clippy#10086 to the beta branch where the bug is still present.

I just cherry-picked the commit.

cc @rust-lang/clippy

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2022
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had this on my to-do list for next week.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

📌 Commit 67745d4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@bors
Copy link
Collaborator

bors commented Dec 31, 2022

⌛ Testing commit 67745d4 with merge 51b0345...

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 51b0345 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2022
@bors bors merged commit 51b0345 into rust-lang:beta Dec 31, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 31, 2022
@matthiaskrgr matthiaskrgr deleted the beta_clippy branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants